It's perfectly acceptable for a module to only support the

2008-02-22  Dominic Lachowicz  <domlachowicz@gmail.com>

        * gdk-pixbuf/queryloaders.c (loader_sanity_check): It's perfectly acceptable
        for a module to only support the save_to_callback() method if it marks itself
        as WRITABLE

svn path=/trunk/; revision=19632

diff --git a/ChangeLog b/ChangeLog
index 5d75543528913b38aeaaeeaaeed34f747b1b1907..e7121ced4fc6b63fcca052c61396a3094e6a82c3 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-02-22  Dominic Lachowicz  <domlachowicz@gmail.com>
+
+       * gdk-pixbuf/queryloaders.c (loader_sanity_check): It's perfectly acceptable
+       for a module to only support the save_to_callback() method if it marks itself
+       as WRITABLE
+       
 2008-02-16  Matthias Clasen  <mclasen@redhat.com>
        
        * configure.in: Bump version

diff --git a/gdk-pixbuf/queryloaders.c b/gdk-pixbuf/queryloaders.c
index 11be6036ca7dc492a7043775ba3288eda7eebb9d..6a3a7c5694fac29abe90ed64e1394b411fa55cd0 100644 (file)
--- a/gdk-pixbuf/queryloaders.c
+++ b/gdk-pixbuf/queryloaders.c
@@ -104,7 +104,7 @@ loader_sanity_check (const char *path, GdkPixbufFormat *info, GdkPixbufModule *v
                goto error;
        }
 
-       if ((info->flags & GDK_PIXBUF_FORMAT_WRITABLE) && !vtable->save) 
+       if ((info->flags & GDK_PIXBUF_FORMAT_WRITABLE) && !(vtable->save || vtable->save_to_callback)) 
        {
                error = "loader claims to support saving but doesn't implement save";
                goto error;